Skip to content

Improve extend #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 19, 2018
Merged

Improve extend #1203

merged 8 commits into from
Nov 19, 2018

Conversation

vtrifonov
Copy link
Contributor

@vtrifonov vtrifonov commented Nov 6, 2018 •
edited
Loading

Related to #1181

@vtrifonov vtrifonov changed the base branch from master to release November 6, 2018 14:38
@vmutafov
Copy link
Contributor

vmutafov commented Nov 9, 2018

test

@vmutafov
Copy link
Contributor

vmutafov commented Nov 9, 2018

resume

@vmutafov
Copy link
Contributor

vmutafov commented Nov 9, 2018

test qsf ngapps

@vtrifonov vtrifonov changed the title Trifonov/improve extend Improve extend Nov 9, 2018
@vmutafov
Copy link
Contributor

test

@vtrifonov vtrifonov changed the base branch from release to master November 16, 2018 08:42
@vtrifonov
Copy link
Contributor Author

test

1 similar comment
@vtrifonov
Copy link
Contributor Author

test

@vmutafov vmutafov merged commit 8ee88c2 into master Nov 19, 2018
@farfromrefug
Copy link
Contributor

@vmutafov thanks for that PR. But I wondering if using a regex is really necessary here. I think a simple indexOf is enough and is less expensive
https://jsperf.com/regexp-vs-indexof

@vtrifonov vtrifonov deleted the trifonov/improve-extend branch November 23, 2018 14:57
@vtrifonov
Copy link
Contributor Author

We've replaced the regex with index of here #1215

@farfromrefug
Copy link
Contributor

@vtrifonov excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vmutafov vmutafov vmutafov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtrifonov @vmutafov @farfromrefug