fix: cyclic task dependency with nativescript-plugin-firebase plugin #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtrifonov
approved these changes
Dec 3, 2018
vtrifonov
deleted the
kddimitrov/fix-cyclic-task-dependency-error-with-firebase-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cyclic task dependency with nativescript-plugin-firebase plugin
Description
Invoking
bundleDebugreordered tasks ingradlebuild in a manner that caused themergeDebugAssetsto be executed before the metadata was generated by thebuildMetadatatask. This led to addingcurrentTask.dependsOn(buildMetadata);, which fixed the problem, but caused cyclic task dependency issues, when the nativescript-plugin-firebase plugin is used.The solution is to use
shouldRunAfterinstead ofdependsOn, which will fix the ordering in the general case, but ignore the rule if a cyclic dependency issue is detected. Reference forshouldRunAfterhere.Does your commit message include the wording below to reference a specific issue in this repo?
Related Pull Requests
#1217
Does your pull request have unit tests?