Skip to content

Use the new ScriptCompiler::CreateCodeCache API to produce script caches #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Use the new ScriptCompiler::CreateCodeCache API to produce script caches #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test-app/runtime/src/main/cpp/ModuleInternal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,15 +379,12 @@ Local<Script> ModuleInternal::LoadScript(Isolate* isolate, const string& path, c
script = maybeScript.ToLocalChecked();
} else {
tns::instrumentation::Frame frame("Compile, no cache");
if (Constants::V8_CACHE_COMPILED_CODE) {
option = ScriptCompiler::kProduceCodeCache;
}
auto maybeScript = ScriptCompiler::Compile(isolate->GetCurrentContext(), &source, option);
if (maybeScript.IsEmpty() || tc.HasCaught()) {
throw NativeScriptException(tc, "Cannot compile " + path);
}
script = maybeScript.ToLocalChecked();
SaveScriptCache(source, path);
SaveScriptCache(script, path);
}

DEBUG_WRITE("Compiled script (module %s)", path.c_str());
Expand Down Expand Up @@ -459,16 +456,19 @@ ScriptCompiler::CachedData* ModuleInternal::TryLoadScriptCache(const std::string
return new ScriptCompiler::CachedData(reinterpret_cast<uint8_t*>(data), length, ScriptCompiler::CachedData::BufferOwned);
}

void ModuleInternal::SaveScriptCache(const ScriptCompiler::Source& source, const std::string& path) {
void ModuleInternal::SaveScriptCache(const Local<Script> script, const std::string& path) {
if (!Constants::V8_CACHE_COMPILED_CODE) {
return;
}

tns::instrumentation::Frame frame("SaveScriptCache");

int length = source.GetCachedData()->length;
Local<UnboundScript> unboundScript = script->GetUnboundScript();
ScriptCompiler::CachedData* cachedData = ScriptCompiler::CreateCodeCache(unboundScript);

int length = cachedData->length;
auto cachePath = path + ".cache";
File::WriteBinary(cachePath, source.GetCachedData()->data, length);
File::WriteBinary(cachePath, cachedData->data, length);
}

ModuleInternal::ModulePathKind ModuleInternal::GetModulePathKind(const std::string& path) {
Expand Down
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/ModuleInternal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class ModuleInternal {

v8::ScriptCompiler::CachedData* TryLoadScriptCache(const std::string& path);

void SaveScriptCache(const v8::ScriptCompiler::Source& source, const std::string& path);
void SaveScriptCache(const v8::Local<v8::Script> script, const std::string& path);

ModulePathKind GetModulePathKind(const std::string& path);

Expand Down