Skip to content

Fix usage of weakJavaObjectToID.remove() #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Fix usage of weakJavaObjectToID.remove() #1259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeeec21
Fix usage of weakJavaObjectToID.remove()
vmutafov Jan 31, 2019
04a1fc2
Merge branch 'master' into vmutafov/fix-runtime-weakref-leak
vtrifonov Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/java/com/tns/Runtime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ private boolean makeInstanceWeakAndCheckIfAlive(int javaObjectID) {
if (instance == null) {
// The Java was moved from strong to weak, and then the Java instance was collected.
weakInstances.remove(javaObjectID);
weakJavaObjectToID.remove(javaObjectID);
weakJavaObjectToID.remove(ref);
return false;
} else {
return true;
Expand Down