Skip to content

Refactor build.gradle not to add configuration:'default' #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Refactor build.gradle not to add configuration:'default' #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions test-app/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ dependencies {
println "\t + adding nativescript runtime package dependency: $runtime"
project.dependencies.add("implementation", [name: runtime, ext: "aar"])
} else {
implementation project(path: ':runtime', configuration: 'default')
implementation project(':runtime')
}

}
Expand Down Expand Up @@ -475,12 +475,17 @@ task extractAllJars {
def buildType = project.selectedBuildType == "release" ? "Release" : "Debug"
def iter = []
Pattern pattern = Pattern.compile("^(.+)${buildType}CompileClasspath\$")
def artifactType = Attribute.of('artifactType', String)
configurations.all { config ->
Matcher matcher = pattern.matcher(config.name)
if (matcher.find() || config.name == "${buildType.toLowerCase()}CompileClasspath") {
config.resolve().each {
if (!iter.contains(it)) {
iter.push(it)
config.incoming.artifactView {
attributes {
it.attribute(artifactType, 'jar')
}
}.artifacts.each {
if (!iter.contains(it.file)) {
iter.push(it.file)
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions test-app/runtime/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ project.ext._buildToolsVersion = "28.0.3"
android {
sourceSets {
main {
def defaultSrcPath = "src/main/java";
def defaultSrcPath = "src/main/java"
def bindingGeneratorSourcePath = new File(project(":runtime-binding-generator").projectDir, defaultSrcPath)

// embedd runtime binding generator in runtime, while keeping it in a sperate project
// embed runtime binding generator in runtime, while keeping it in a separate project
java.srcDirs = [bindingGeneratorSourcePath, defaultSrcPath]
}
}
Expand Down