Skip to content

Conversation

mbektchiev
Copy link
Contributor

@mbektchiev mbektchiev commented Mar 15, 2019

  • Fix runSbg's dependencies, outputs and inputs
  • Add collectAllJars dependency to extractAllJars
  • Refactor extractAllJars into separate tasks and make them
    run in parallel
    • Rename exploded archive directories to MD5 hashes of the full path
      of the input file
    • Set the AAR/JAR file as an input to each task and it's output dir
      as an output
    • Define a cleanup task which deletes orphaned extracted directories
      (e.g. by a plugin removal)
    • Speed up explodeAar function. It was extracting jar files from
      AARs byte by byte.

refs #1293, #1257

@mbektchiev mbektchiev added this to the 5.3.0 milestone Mar 15, 2019
@mbektchiev mbektchiev self-assigned this Mar 15, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 15, 2019
@mbektchiev mbektchiev changed the title fix(gradle): Fix SBG and collectAllJars tasks dependencies fix(gradle): Fix runSbg and collectAllJars tasks dependencies Mar 15, 2019
@mbektchiev mbektchiev changed the title fix(gradle): Fix runSbg and collectAllJars tasks dependencies fix(gradle): Fix runSbg and collectAllJars tasks' dependencies Mar 15, 2019
* Fix `runSbg`'s dependencies, outputs and inputs
* Add `collectAllJars` dependency to `extractAllJars`
* Refactor `extractAllJars` into separate tasks and make them
run in parallel
  * Rename exploded archive directories to MD5 hashes of the full path
of the input file
  * Set the AAR/JAR file as an input to each task and it's output dir
as an output
  * Define a cleanup task which deletes orphaned extracted directories
(e.g. by a plugin removal)
  * Speed up explodeAar function. It was extracting `jar` files from
`AAR`s byte by byte.

refs #1293
@mbektchiev mbektchiev force-pushed the bektchiev/fix-sbg-jars-deps branch from cb6dcf1 to ed72de1 Compare March 15, 2019 12:34
@vtrifonov vtrifonov merged commit 060a268 into master Mar 15, 2019
@ghost ghost removed the bug label Mar 15, 2019
@vtrifonov vtrifonov deleted the bektchiev/fix-sbg-jars-deps branch March 15, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants