Fix issues with generic methods handling in the SBG #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmutafov
force-pushed
the
vmutafov/sbg-refactoring-fix
branch
from
c729ed3 to
228a386
Compare
vtrifonov
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fixes issues regarding the handling of generic methods with own generic parameters (not coming from the class declaration), creation of the generic hierarchy view also had a problem with deeply nested in the hierarchy generic interfaces. Commit also introduces better handling of cases where classes can not be extended(final classes, non public constructor arguments, etc.). Tested with extend of all classes found in the android sdk and overriding all their methods.