Throw exception if no snapshot is found and check for TNSSnapshot.blob #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtrifonov
approved these changes
Sep 30, 2019
|
test --android-runtime-tests |
1 similar comment
|
test --android-runtime-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if there is no snapshot found when there should be, no exception is thrown and the runtime crashes at a later point. With no exception thrown, diagnosing where the issue is, becomes a little bit harder having to check the APK or even debug it.
This PR introduces an exception throw when no snapshot is found and also introduces a check for
TNSSnapshot.blobremoving the need for the CLI team to rename theTNSSnapshot.blobtosnapshot.blob.