Skip to content

Merge release to master #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 5, 2019
Merged

Merge release to master #1532

merged 8 commits into from
Nov 5, 2019

Conversation

mbektchiev
Copy link
Contributor

@mbektchiev mbektchiev commented Nov 5, 2019 •
edited
Loading

No description provided.

@mbektchiev mbektchiev requested a review from vmutafov November 5, 2019 08:54
@mbektchiev mbektchiev self-assigned this Nov 5, 2019
@cla-bot cla-bot bot added the cla: yes label Nov 5, 2019
@mbektchiev mbektchiev requested a review from vtrifonov November 5, 2019 08:56
@mbektchiev mbektchiev merged commit f3657ad into master Nov 5, 2019
@mbektchiev mbektchiev deleted the bektchiev/merge-release-to-master branch November 5, 2019 09:38
@farfromrefug
Copy link
Contributor

@mbektchiev is this already available in 6.2.0?

@mbektchiev
Copy link
Contributor Author

Yes, with this PR, we're just merging the commits to our master branch.

@farfromrefug
Copy link
Contributor

@mbektchiev OK i was kind of lost. From npm https://www.npmjs.com/package/tns-android 6.2.0 was released 7 days ago. But you made that merge yesterday.
But looking at my build project, i can see the changes!

Thanks!

@mbektchiev
Copy link
Contributor Author

Yes, this PR is just bookkeeping. We use 2 development branches master and release which correspond to the @next and @rc tags respectively. These commits were done after we did the code freeze for 6.2.0 and that's why they were in release only, now that the PR is merged, they are present in master (and @next) as well.

@farfromrefug
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmutafov vmutafov Awaiting requested review from vmutafov

1 more reviewer

@vtrifonov vtrifonov vtrifonov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mbektchiev mbektchiev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbektchiev @farfromrefug @vtrifonov @vmutafov