Skip to content

Bug/debugger in line #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2020
Merged

Bug/debugger in line #1641

merged 2 commits into from
Oct 16, 2020

Conversation

dev4s
Copy link
Contributor

@dev4s dev4s commented Oct 12, 2020

This fixes #1640

@cla-bot cla-bot bot added the cla: yes label Oct 12, 2020
rigor789 added a commit that referenced this pull request Sep 8, 2021
@rigor789
fix(chrome-devtools): Elements tab
e935a61 
This partially reverts the fix from #1641 as it ends up never calling `m_backend->getDocument`.

This may bring back an issue from #1640 - though was unable to reproduce with latest everything.
@rigor789 rigor789 mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@NathanaelA NathanaelA NathanaelA approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NathanaelA NathanaelA

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In line debugger - can't connect through websocket
2 participants
@dev4s @NathanaelA