Skip to content

feat: add class name to native objects #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022
Merged

feat: add class name to native objects #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
469e914
feat: add class name to native objects
edusperoni Aug 29, 2022
93bb0b9
test: add unit tests for class names
edusperoni Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test-app/app/src/main/assets/app/tests/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,4 +1737,12 @@ describe("Tests ", function () {
expect(com.tns.tests.LogcatUtil.logcatContainsString(str.slice(0, -1) + "...")).toBe(true);
});
}
it("should show the correct class name for native object", function () {
var obj = new java.lang.Object();
expect(java.lang.Object.name).toBe('java.lang.Object');
expect(obj.constructor.name).toBe('java.lang.Object');
var bool = new java.lang.Boolean(false);
expect(java.lang.Boolean.name).toBe('java.lang.Boolean');
expect(bool.constructor.name).toBe('java.lang.Boolean');
});
});
9 changes: 9 additions & 0 deletions test-app/runtime/src/main/cpp/MetadataNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,15 @@ Local<FunctionTemplate> MetadataNode::GetConstructorFunctionTemplate(Isolate* is
auto isInterface = s_metadataReader.IsNodeTypeInterface(treeNode->type);
auto funcCallback = isInterface ? InterfaceConstructorCallback : ClassConstructorCallback;
ctorFuncTemplate = FunctionTemplate::New(isolate, funcCallback, ctorCallbackData);
auto currentNode = treeNode;
std::string finalName(currentNode->name);
while (currentNode->parent) {
if (!currentNode->parent->name.empty()) {
finalName = currentNode->parent->name + "." + finalName;
}
currentNode = currentNode->parent;
}
ctorFuncTemplate->SetClassName(v8::String::NewFromUtf8(isolate, finalName.c_str()).ToLocalChecked());
ctorFuncTemplate->InstanceTemplate()->SetInternalFieldCount(static_cast<int>(ObjectManager::MetadataNodeKeys::END));

Local<Function> baseCtorFunc;
Expand Down