add support for ByteBuffer to ArrayBuffer conversion

[slavchev]

This PR deprecates #365

[ns-bot]

💚

[ns-bot]

💔

[ns-bot]

💚

[slavchev]

ping @atanasovg @blagoev @Pip3r4o @Plamen5kov

[ns-bot]

💚

[Plamen5kov]

👍

[ns-bot]

💚

[andy-maca]

@slavchev Seems current only direct byte buffer is supported, how about heap buffere? I am using nativescript-websocket plugin which is using java-websocket, but unfortunately it returns java.nio.HeapByteArray for every received message, when I use ArrayBuffer.from(..), there will be error message 'Error: Direct ByteBuffer expected)', so how can I get rid of this without doing data copy? Thanks.

[slavchev]

@andy-maca Currently I don't work on NativeScript Android Runtime, but I looked at the implementation and it should be easy to extend it. I used isDirect check for performance reasons, but this constraint can be relaxed. It's a trade-off between copying/non-copying operations and usability. You can continue the discussion with the team /cc @vtrifonov @darind @mbektchiev @etabakov

[andy-maca]

@slavchev Thanks. I just created a new issue #1060