Skip to content

Enable JsDebugger on first debugger connect (do not stop on debugger;… #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Enable JsDebugger on first debugger connect (do not stop on debugger;… #401

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b00a218
Enable JsDebugger on first debugger connect (do not stop on debugger;…
blagoev Mar 23, 2016
c40059d
remove js debugger disable flagging
blagoev Mar 23, 2016
b8e2c3c
merge master branch
Apr 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/src/com/tns/JsDebugger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ public class JsDebugger
private byte[] LINE_END_BYTES;

private HandlerThread handlerThread;

public boolean jsDebuggerEnabled;

public JsDebugger(Context context, Logger logger, ThreadScheduler threadScheduler)
{
Expand Down Expand Up @@ -124,7 +126,12 @@ public void close() throws IOException
try
{
LocalSocket socket = serverSocket.accept();


if (!jsDebuggerEnabled)
{
enable();
}

logger.write("NativeScript Debugger new connection on: " + socket.getFileDescriptor().toString());

//out (send messages to node inspector)
Expand Down Expand Up @@ -492,6 +499,7 @@ private void enableAgent()
{
logger.write("Enabling NativeScript Debugger Agent");
enable();
jsDebuggerEnabled = true;
}

@RuntimeCallable
Expand All @@ -500,7 +508,6 @@ private void disableAgent()
logger.write("Disabling NativeScript Debugger Agent");
disable();


String message = "{\"seq\":0,\"type\":\"request\",\"command\":\"disconnect\"}";

byte[] cmdBytes;
Expand Down Expand Up @@ -580,12 +587,13 @@ public void start()

registerEnableDisableDebuggerReceiver(handler);

logger.write("Enabling Debugger Agent");
enable();

boolean shouldDebugBreak = getDebugBreakFlagAndClearIt();
if (shouldDebugBreak)
{
logger.write("Enabling Debugger Agent");
enable();
jsDebuggerEnabled = true;

debugBreak();
}
}
Expand Down