fix issue #397 #402
fix issue #397 #402
Conversation
|
💚 |
|
Isn't this fix working #401 |
|
#401 works fine. I just went for a simpler solution. Yesterday I fixed NativeScript/nativescript-cli#1640 so now a simple |
|
I prefer to keep it as simple as possible. That's why I fixed the bug the CLI and then there is no need for workarounds it the runtime code. Win-win situation. |
|
Just to clarify. The #401 pull is related to the bug when a debugger; statement exists in code and when the app run it should not stop there if no debugger is connected. The #401 pull fixes this and includes the changes you did in this PR. To me it is irrelevant which PR gets in, we just need to make sure the debugger statements issue is fixed as well. |
|
@slavchev Have you tested this with the {N} VS code extension. It seems to me the extension will not work when doing an Attach command. |
src/src/com/tns/JsDebugger.java
Outdated
| logger.write("Enabling Debugger Agent"); | ||
| enable(); | ||
|
|
||
| boolean shouldDebugBrake = getDebugBreakFlagAndClearIt(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
run ci |
5 participants
No description provided.