Skip to content

update gradle to remove npm install from it #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2016
Merged

update gradle to remove npm install from it #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions ...ject-template-gradle/build-tools/android-static-binding-generator/ast-parser/package.json
View file
Open in desktop

This file was deleted.

25 changes: 1 addition & 24 deletions build/project-template-gradle/build-tools/android-static-binding-generator/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,28 +44,6 @@ task generateInterfaceNamesList() {
}
}

// won't run if node_modules are installed
task runNpmInstallForAstParser () {

//check this way so it doesn't slow down the build by snapshot-ing the node_modules
outputs.upToDateWhen {
(new File("$astParserDir/node_modules")).exists()
}

doFirst {
exec {
workingDir astParserDir

if(isWinOs) {
commandLine "cmd", "/c", "npm", "install"
}
else {
commandLine "npm", "install"
}
}
}
}

// if there are new dependencies the parser will run again
task runAstParser () {
inputs.files fileTree(dir: absoluteJsCodeDir)
Expand Down Expand Up @@ -105,7 +83,6 @@ task generateBindings() {
}
}

runNpmInstallForAstParser.dependsOn(generateInterfaceNamesList)
runAstParser.dependsOn(runNpmInstallForAstParser)
runAstParser.dependsOn(generateInterfaceNamesList)
generateBindings.dependsOn(runAstParser)