Update project template in order to execute Runtime.run() method at t… #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he end of Application.onCreate() method
|
ping @NativeScript/android-runtime |
|
💚 |
| public void onCreate() { | ||
| super.onCreate(); | ||
| new RuntimeHelper(this).initRuntime(); | ||
| com.tns.Runtime runtime = new RuntimeHelper(this).initRuntime(); |
There was a problem hiding this comment.
can we do this like this
com.tns.Runtime runtime = new RuntimeHelper(this);
runtime.initRuntime()
that line look very strange to me..
Other way I would do it is to make this a static method so
com.tns.Runtime runtime = RuntimeHelper.initRuntime(this);
|
💚 |
|
ping @galexandrov this change will affect AppBuilder related things (e.g. {N} Companion App) |
|
👍 This makes the flow more what the user would expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he end of Application.onCreate() method