Plamen5kov/console api #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when __toFrontEnd(message) is called from JS the messages is sent to Chrome Dev Tools still need to choose if we wan't to export this new function or use the old one - __consoleMessage
|
💚 |
|
run CI |
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
__consoleMessageto send console messages to chrome dev tools front end. If no debugger client is attached calling__consoleMessageis a no operation.Furthermore there will be no double logging in vs code console, due to the fact, the console api we are using in this PR is using the Runtime domain, and the event from the Console domain "messageAdded` is no longer fired.