Fix for memory leak2 #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 22, 2015 02:53
…upports 512 items. Doing some work in a loop that references a several variables can cause this table to exceed and then the app will crash with the following error: JNI ERROR (app bug): local reference table overflow (max=512) JNI local reference table (0xb9987968) dump: Failed adding to JNI local ref table (has 512 entries)
|
Can one of the admins verify this patch? |
|
I'm having the same problem. I hope this fix will be included soon. |
slavchev
pushed a commit
that referenced
this pull request
May 29, 2015
|
@NathanaelA Thank you for reporting this issue. I reviewed your commits and wrapped the references into |
slavchev
pushed a commit
that referenced
this pull request
Jun 1, 2015
Plamen5kov
force-pushed
the
master
branch
5 times, most recently
from
dc2cf97 to
5031087
Compare
|
quoting @slavchev:
The leaks are already fixed, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JNI apparently caches stuff in a local reference table; it can only supports 512 items. Adding the DeleteLocalRef will eliminate the obj's in the Local Reference Table so the Table doesn't overflow. Once the table overflows the application crashes.