Skip to content

Force delete temporary livesync dir after syncing .xml or .css files #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Force delete temporary livesync dir after syncing .xml or .css files #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion build-artifacts/project-template-gradle/src/main/java/com/tns/NativeScriptSyncService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ public void run() {
int length = input.readInt();
input.readFully(new byte[length]); // ignore the payload
executePartialSync(context, syncDir);
// delete temporary /sync dir after syncing .xml/.css resources
deleteRecursive(syncDir);
executeRemovedSync(context, removedSyncDir);
// delete temporary /removedsync dir after removing files from the project
deleteRecursive(removedSyncDir);

runtime.runScript(new File(NativeScriptSyncService.this.context.getFilesDir(), "internal/livesync.js"));
try {
Expand Down Expand Up @@ -157,7 +161,11 @@ private void deleteRecursive(File fileOrDirectory) {
}
}

fileOrDirectory.delete();
boolean success = fileOrDirectory.delete();

if (!success && fileOrDirectory.isDirectory()) {
android.util.Log.d("Sync", "Failed to delete temp sync directory: " + fileOrDirectory.getAbsolutePath());
}
}

public static boolean isSyncEnabled(Context context) {
Expand Down
10 changes: 9 additions & 1 deletion test-app/app/src/main/java/com/tns/NativeScriptSyncService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ public void run() {
int length = input.readInt();
input.readFully(new byte[length]); // ignore the payload
executePartialSync(context, syncDir);
// delete temporary /sync dir after syncing .xml/.css resources
deleteRecursive(syncDir);
executeRemovedSync(context, removedSyncDir);
// delete temporary /removedsync dir after removing files from the project
deleteRecursive(removedSyncDir);

runtime.runScript(new File(NativeScriptSyncService.this.context.getFilesDir(), "internal/livesync.js"));
try {
Expand Down Expand Up @@ -157,7 +161,11 @@ private void deleteRecursive(File fileOrDirectory) {
}
}

fileOrDirectory.delete();
boolean success = fileOrDirectory.delete();

if (!success && fileOrDirectory.isDirectory()) {
android.util.Log.d("Sync", "Failed to delete temp sync directory: " + fileOrDirectory.getAbsolutePath());
}
}

public static boolean isSyncEnabled(Context context) {
Expand Down