Use HashSet for duplication detection #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I'll agree that using a HashSet is better since we do not need the random index access of the List, so element lookup would be faster, though I do not expect any noticeable speed up in class generation. |
petekanev
approved these changes
May 31, 2017
|
run ci |
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The duplication detection is now amortized O(n) instead of O(n^2).
Does your commit message include the wording below to reference a specific issue in this repo?
No issue opened for this trivial change.
Related Pull Requests
Blame #693 for the crap implementation.
Does your pull request have unit tests?
This is a performance fix and thus cannot be unit tested.