on livesync delete empty folders on exit #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
petekanev
reviewed
Aug 9, 2017
| targetFile.delete(); | ||
| } else { | ||
| deleteRemovedFiles(file, sourceRootAbsolutePath, targetRootAbsolutePath); | ||
| if (targetFile.listFiles().length == 0) { |
There was a problem hiding this comment.
Could you add a comment why that is necessary?
There was a problem hiding this comment.
It cleans the empty folders after it's done deleting files.
It's not necessary, I just did it so we don't pollute the device with empty folders. Plus to keep behavior the same as on iOS devices.
I'll comment it in the code no problem.
|
💚 |
petekanev
reviewed
Aug 10, 2017
| } else { | ||
| deleteRemovedFiles(file, sourceRootAbsolutePath, targetRootAbsolutePath); | ||
|
|
||
| // this is done so empty folders, if any, are deleted after we're don deleting files. |
There was a problem hiding this comment.
The comment is only present in the test-app class. Could you do the same for the build template?
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime deletes unnecessary folders on livesync
problem
When CLI livesyncs, android runtime needs to remove old files and it does, but it leaves empty folders
solution
check if folders are empty on exit and delete if so