add a warning if no bindings.txt file was found #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Plamen5kov Shouldn't we terminate the build with an exception? If no scripts have been parsed, then there likely won't be any scripts to run the application off of. |
|
💔 |
|
I dont't know why I've put warning in the message .. we throw an error... |
Plamen5kov
force-pushed
the
plamen5kov/better-js-parsing-warnings
branch
from
4aa04a7 to
8833114
Compare
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #833
problem
When gradle can't find
.jsfiles to parse it doesn't show an ok Error, pointing out the problemsolution
Throw an error that describes the issue, in this case, to help the user figure out the problem.