Metadata generator is more tolerable now #842
Merged
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
|
run uitests |
|
run ci |
|
💔 |
Plamen5kov
reviewed
Sep 11, 2017
| ClassDescriptor clazz = ClassRepo.findClass(className); | ||
| generate(clazz, root); | ||
| if (clazz == null) { | ||
| throw new ClassNotFoundException("Class " + className + " not found in the input jars."); |
There was a problem hiding this comment.
Change jars to libraries, since from the user perspective .aar files are not jars.
Plamen5kov
approved these changes
Sep 11, 2017
| // Should we worry about this? If classes would crash, that would happen during the compilation step | ||
| // which occurs before the metadata generation | ||
|
|
||
| // throw new IllegalArgumentException(errMsg); |
There was a problem hiding this comment.
We needed this check when metadata was generated on the basis of .dex files. It's now obsolete because, as you said, the compilation task will take care of providing an understandable error for the user, so we don't need to.
You can remove the comment and leave the code as it is, without the throw statement.
petekanev
force-pushed
the
pete/improve-metadata
branch
from
6792a21 to
7438f48
Compare
|
💚 |
petekanev
force-pushed
the
pete/improve-metadata
branch
from
7438f48 to
d9e81d7
Compare
|
💔 |
|
run ci |
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #832 by making the following small changes:
when collecting classes from input jars, do not crash on clashing classes (classes that are already brought in from another library). The assumption here is that the build will crash at earlier point during the java compilation step, and it should not concern the metadata generator.
(e.g. An android library depends on appache http library, but if imported in gradle as a dependency, the class collection logic in the metadata generation would fail, complaining that 3 classes coincide in name - some of the appache http classes are left inside the android sdk packages for whatever legacy reasons they have)
when traversing a class's methods/fields, do not skip class if the parameter of a single method is not found in the ClassLoader. Instead continue, and try to generate as much metadata as possible for the class being analyzed.