Skip to content

Plamen5kov/update gradle to latest stable #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 12, 2017
Merged

Plamen5kov/update gradle to latest stable #849

merged 7 commits into from
Oct 12, 2017

Conversation

Plamen5kov
Copy link
Contributor

@Plamen5kov Plamen5kov commented Sep 20, 2017 •
edited
Loading

  • update gradle version to 4.1 android plugin for gradle to 2.3.3
  • use cmake for builds
  • restructure project so it's easily integratable with android studio
  • update ndk to 15c and the android-runtime README.md
  • update travis build

@Plamen5kov Plamen5kov mentioned this pull request Oct 11, 2017
Closed
petekanev
petekanev approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@petekanev petekanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after all builds have passed.

@Plamen5kov
Copy link
Contributor Author

Currently, the build machine config needs to be changed in order for that to happen. I'll take care of it, along with rebasing to master.

@Plamen5kov
update runtime project
5760d6d 
update gradle of projects
update gitmodules and gitignore
update root build gradle
add new project structure
named new module so no breaking changes
updated gitignore
after gitignore update
update build.gradle
mssing build-artifacts folder
stop ignoring build-artifactse
add optimization flags (fix warnings later)
update readme
@Plamen5kov
add iml file or android studio does not open the project ok
624826e
@Plamen5kov Plamen5kov force-pushed the plamen5kov/update-gradle-to-latest-stable branch from 33457d6 to 624826e Compare October 11, 2017 13:59
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@Plamen5kov Plamen5kov force-pushed the plamen5kov/update-gradle-to-latest-stable branch from 82a741f to dcf26dd Compare October 11, 2017 15:21
@NativeScript NativeScript deleted a comment from petekanev Oct 11, 2017
@NativeScript NativeScript deleted a comment from dtopuzov Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@NativeScript NativeScript deleted a comment from ns-bot Oct 11, 2017
@ns-bot
Copy link

ns-bot commented Oct 11, 2017

💚

@ns-bot
Copy link

ns-bot commented Oct 11, 2017

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Oct 11, 2017

💚

@ns-bot
Copy link

ns-bot commented Oct 12, 2017

💚

@ns-bot
Copy link

ns-bot commented Oct 12, 2017

💚

@Plamen5kov Plamen5kov merged commit 7897e2d into master Oct 12, 2017
@Plamen5kov Plamen5kov deleted the plamen5kov/update-gradle-to-latest-stable branch October 12, 2017 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@petekanev petekanev petekanev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Plamen5kov @ns-bot @petekanev