Skip to content

Conversation

petekanev
Copy link
Contributor

Apply the user-defined configuration of app.gradle before any other plugin-defined configs, during a Gradle build.

Doing that will ensure that project-external properties defined as project.ext will be available throughout the configuration step for plugin gradle scripts.

Finally the user configuration will be reapplied, in order to apply settings the plugin scripts might have overridden.

@petekanev petekanev self-assigned this Nov 9, 2017
@petekanev petekanev requested a review from Plamen5kov November 9, 2017 09:34
@ns-bot
Copy link

ns-bot commented Nov 9, 2017

💔

@ns-bot
Copy link

ns-bot commented Nov 9, 2017

💔

1 similar comment
@ns-bot
Copy link

ns-bot commented Nov 9, 2017

💔

@dtopuzov
Copy link
Contributor

dtopuzov commented Nov 9, 2017

run ci

@ns-bot
Copy link

ns-bot commented Nov 9, 2017

💔

@petekanev
Copy link
Contributor Author

Jenkins CI fails because of the different directory structure defined by the changes to the project + Android Studio integration. Code and Scripts build successfully however.

@petekanev petekanev merged commit 3a2d3b2 into release Nov 9, 2017
@petekanev petekanev deleted the pete/fix-appgradle-apply branch November 9, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants