refactored: classNameSeparator #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
… and runtime changed tests so they can work with the new changes
Plamen5kov
force-pushed
the
plamen5kov/separators
branch
from
f61e4ac to
90eadde
Compare
|
💚 |
slavchev
pushed a commit
that referenced
this pull request
Jun 3, 2015
refactored: classNameSeparator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLASS_NAME_LOCATION_SEPARATOR is now a constant in binding generator (in Dump.java)… and runtime (in Constants.h).
We do this because of java class naming conventions and to sync with future feature for AOT created classes for specific js user code.
changed tests so they can work with the new changes