fix(project-build-script): change compile -> implementation #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
1 similar comment
|
💔 |
petekanev
force-pushed
the
pete/fix-compile-deps
branch
from
60d4521 to
8b7870b
Compare
|
💔 |
petekanev
force-pushed
the
pete/fix-compile-deps
branch
from
8b7870b to
83575d6
Compare
|
💔 |
petekanev
force-pushed
the
pete/fix-compile-deps
branch
from
83575d6 to
2b12f03
Compare
|
💔 |
petekanev
force-pushed
the
pete/fix-compile-deps
branch
from
2b12f03 to
7fd5f0a
Compare
|
💔 |
|
💚 |
darind
approved these changes
Apr 12, 2018
|
💚 |
|
💔 |
|
💚 |
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993 by removing the use of the deprecated
compilemethods when declaring project dependencies, and slightly altering the dependency artifacts traversal logic.Update: the fix works when tested locally on my Windows workstation with Android Build-Tools 28.0.0-rc1, however it fails on both the Jenkins and Travis CI