Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict nested outlet back navigation scope #54

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Feb 6, 2022

PR Checklist

What is the current behavior?

We mark all outlet keys as being backed on.

What is the new behavior?

We only mark keys that are of a higher nesting level than the current key as being backed on.

Fixes #49.

@edusperoni edusperoni marked this pull request as ready for review February 9, 2022 18:53
@NathanWalker NathanWalker merged commit 5a88bc2 into main Feb 9, 2022
@NathanWalker NathanWalker deleted the fix/nested-frame-back branch February 9, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back navigation in nested page router outlets fails after consecutive invocations
2 participants