Skip to content

docs(android): add note for adoptopensdk error #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2021
Merged

docs(android): add note for adoptopensdk error #10

merged 6 commits into from
Jun 14, 2021

Conversation

bgrand-ch
Copy link
Contributor

No description provided.

@cla-bot
Copy link

cla-bot bot commented Apr 13, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @bgrand-ch.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@bgrand-ch
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Apr 13, 2021

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Apr 13, 2021
@NathanWalker
Copy link
Contributor

NathanWalker commented Jun 13, 2021

@bgrand-ch @rigor789 I just ran into trouble with the docs around all this now on a new machine (M1).

brew install --cask adoptopenjdk

I assume this should setup java JDK, however doesn't seem to do anything?

@NathanWalker
Copy link
Contributor

NathanWalker commented Jun 13, 2021

M1Air % java --version
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.

Are these commands supposed to resolve that?

brew tap AdoptOpenJDK/openjdk
brew install --cask adoptopenjdk14

Thought I would try following the docs to the letter (in past I often setup differently/manually) but does seem new docs around this lead to mixed or frustrating results (or perhaps not clear enough, not sure) - bit lost.

@bgrand-ch
Copy link
Contributor Author

bgrand-ch commented Jun 13, 2021

@NathanWalker Hello, try with adoptopenjdk15 and ns clean after installation. For me, that works fine 🤔

@NathanWalker
Copy link
Contributor

Thanks @bgrand-ch so just brew install --cask adoptopenjdk15 and then java --version worked for you? Anything you had to put in zshrc or bash_profile?

@bgrand-ch
Copy link
Contributor Author

@NathanWalker

brew tap AdoptOpenJDK/openjdk
brew install --cask adoptopenjdk15
ns clean

with zshrc profile

@cla-bot

This comment has been minimized.

@cla-bot cla-bot bot removed the cla: yes label Jun 13, 2021
@cla-bot

This comment has been minimized.

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @bgrand-ch.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@bgrand-ch
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jun 14, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @bgrand-ch.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot
Copy link

cla-bot bot commented Jun 14, 2021

The cla-bot has been summoned, and re-checked this pull request!

@bgrand-ch
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jun 14, 2021

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Jun 14, 2021
@rigor789 rigor789 merged commit 7bbd2f9 into NativeScript:develop Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants