Skip to content

feat: add device frame to screenshots #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2021
Merged

feat: add device frame to screenshots #16

merged 2 commits into from
Apr 24, 2021

Conversation

janoshrubos
Copy link
Collaborator

Wrapping screenshot images with a device frame on ios and android with

/// frame ios

<img src="https://raw.githubusercontent.com/NativeScript/nativescript-app-templates/master/packages/template-blank/tools/assets/appTemplate-ios.png">

///

/// frame android

<img src="https://raw.githubusercontent.com/NativeScript/nativescript-app-templates/master/packages/template-blank/tools/assets/appTemplate-android.png">

///

would render them like this:

Screenshot 2021-04-20 at 15 18 38

Related to: https://github.com/NativeScript/nativescript-website/pull/4#issue-619320781

@cla-bot cla-bot bot added the cla: yes label Apr 20, 2021
@NathanWalker NathanWalker changed the base branch from develop to chore/group-updates April 24, 2021 21:33
@NathanWalker NathanWalker merged commit f3c5f00 into chore/group-updates Apr 24, 2021
@NathanWalker NathanWalker deleted the feat/device-frame branch April 24, 2021 21:33
NathanWalker pushed a commit that referenced this pull request Apr 24, 2021
@janoshrubos @NathanWalker
feat: add device frame to screenshots (#16)
ee2cf8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janoshrubos @NathanWalker