Skip to content

Added info about adding Java code to App_Resources #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2022

Conversation

isapir
Copy link
Contributor

@isapir isapir commented Apr 9, 2022

@NathanWalker Please edit or provide feedback and I will make changes as needed

@cla-bot
Copy link

cla-bot bot commented Apr 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @isapir.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@isapir
Copy link
Contributor Author

isapir commented Apr 9, 2022

I signed the CLA

@isapir
Copy link
Contributor Author

isapir commented Apr 12, 2022

I don't know why it still says that I'm missing the CLA. That was done a few days ago.
image

@rigor789
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Apr 12, 2022
@cla-bot
Copy link

cla-bot bot commented Apr 12, 2022

The cla-bot has been summoned, and re-checked this pull request!

See https://developer.android.com/studio/releases/sdk-tools

Also updated the link to the parent page of avdmanager documentation as the official page is also out of date, but the parent page shows the correct path
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, added few minor suggestions

@rigor789 rigor789 merged commit f226171 into NativeScript:develop Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants