Skip to content

Conversation

Ombuweb
Copy link
Contributor

@Ombuweb Ombuweb commented Nov 18, 2022

No description provided.

@cla-bot cla-bot bot added the cla: yes label Nov 18, 2022
@bradmartin
Copy link

bradmartin commented Nov 19, 2022

Looks pretty good to me. Any docs covering things the framework is lacking is always 💯 to me. Not sure what's being discussed internally about where/how to structure these so leave that to @rigor789 but the actual change here looks good.

Nice work @Ombuweb

@Ombuweb
Copy link
Contributor Author

Ombuweb commented Nov 19, 2022

😊 Thank you, @bradmartin.

@vallemar
Copy link
Contributor

vallemar commented Apr 6, 2023

Copy link
Collaborator

@ashutosh887 ashutosh887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @NathanWalker

Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes/changes - I'll go ahead and make those changes.

@rigor789 rigor789 self-assigned this Aug 24, 2023
@rigor789 rigor789 merged commit 72c3849 into NativeScript:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants