Skip to content

Conversation

Ombuweb
Copy link
Contributor

@Ombuweb Ombuweb commented Nov 23, 2022

No description provided.

@cla-bot cla-bot bot added the cla: yes label Nov 23, 2022
@Ombuweb Ombuweb marked this pull request as draft November 23, 2022 21:06
@rigor789 rigor789 changed the title docs: initial commit docs: Http Nov 23, 2022
@Ombuweb Ombuweb marked this pull request as ready for review November 24, 2022 14:41
Copy link
Collaborator

@ashutosh887 ashutosh887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the things LGTM

response.content?.toJSON(encoding)
```

Gets the response body as JSON object. The `encoding` is an optional of type `'UTF8' | 'GBK'`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep UTF8 & GBK as external links and on clicking, the CTA could be more detail/some docs page for encoding types

@ashutosh887
Copy link
Collaborator

@NathanWalker Added some comments!

@NathanWalker NathanWalker changed the base branch from main to dev July 28, 2023 03:36
@NathanWalker NathanWalker merged commit fd47d14 into NativeScript:dev Aug 13, 2023
NathanWalker added a commit to Ombuweb/docs that referenced this pull request Aug 13, 2023
Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
NathanWalker added a commit to Ombuweb/docs that referenced this pull request Aug 13, 2023
Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
NathanWalker added a commit to Ombuweb/docs that referenced this pull request Aug 30, 2023
Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants