Skip to content

Updates to documentation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2021
Merged

Updates to documentation #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
391b7bd
Update Readme.md for Facebook authentication
azriel46d Nov 27, 2021
d6f2d3b
Update import file for messaging
azriel46d Nov 27, 2021
264c166
Fix onTokenRefresh to onToken
azriel46d Nov 27, 2021
aad61f5
Update README.md
azriel46d Nov 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/firebase-auth/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,13 @@ import { LoginManager, AccessToken } from '@nativescript/facebook';

LoginManager.logInWithPermissions(['public_profile', 'email']).then((result) => {
// Once signed in, get the users AccesToken
const data = await AccessToken.getCurrentAccessToken();
const data = await AccessToken.currentAccessToken();

// Create a Firebase credential with the AccessToken
const facebookCredential = FacebookAuthProvider.credential(data.accessToken);
const facebookCredential = FacebookAuthProvider.credential(data.tokenString);

// Sign-in the user with the credential
return auth().signInWithCredential(facebookCredential);

firebase().auth().signInWithCredential(facebookAuthCredential);
return firebase().auth().signInWithCredential(facebookCredential);
});


Expand Down Expand Up @@ -227,7 +225,7 @@ import { GoogleSignin } from '@nativescript/google-signin';
GoogleSignin.configure(); // called earlier in the app

GoogleSignin.signIn().then((user) => {
const credential = GoogleAuthProvider.credential(user.accessToken, user.idToken);
const credential = GoogleAuthProvider.credential(user.idToken, user.accessToken);

firebase().auth().signInWithCredential(credential);
});
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase-messaging/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ This module provides a requestPermission method which triggers a native permissi

```ts
import { firebase } from '@nativescript/firebase-core';
import '@nativescript/firebase-crashlytics'; // only needs to be imported 1x
import '@nativescript/firebase-messaging'; // only needs to be imported 1x

async function requestUserPermission() {
const authStatus = await firebase()
Expand Down Expand Up @@ -263,7 +263,7 @@ async function saveTokenToDatabase(token) {


// Listen to whether the token changes
firebase().messaging().onTokenRefresh(token => {
firebase().messaging().onToken(token => {
saveTokenToDatabase(token);

}
Expand Down