Skip to content

Remove defunct V8 external startup data stuff #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 4, 2023
Merged

Remove defunct V8 external startup data stuff #210

merged 3 commits into from
May 4, 2023

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Apr 19, 2023

  • Removes a couple of leftovers from using external startup data, which is no longer supported as per Removal of Snapshots support from NS 7.x NativeScript#8926. No need to update V8 libraries as they are already built for iOS with v8_use_external_startup_data=false.
  • Readme improvement that I had sitting around on my local checkout.

@cla-bot cla-bot bot added the cla: yes label Apr 19, 2023
@ptomato ptomato mentioned this pull request Apr 19, 2023
Merged
@NathanWalker NathanWalker merged commit 36e3dd3 into NativeScript:main May 4, 2023
@ptomato ptomato deleted the rm-snapshot branch May 4, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptomato @rigor789 @NathanWalker