Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): Link active directive: fix adding CSS class #2227

Merged

Conversation

denlysenko
Copy link
Contributor

fixes #2224

@project-bot project-bot bot added this to PRs in Plugins Team Aug 19, 2020
@cla-bot
Copy link

cla-bot bot commented Aug 19, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @denlysenko.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@denlysenko
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 19, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Aug 19, 2020
@NathanWalker NathanWalker merged commit 5e165b5 into NativeScript:master Aug 19, 2020
Plugins Team automation moved this from PRs to Done Aug 19, 2020
@NathanWalker
Copy link
Contributor

Thanks @denlysenko this is published in 10.0.2 now 👍

@denlysenko denlysenko deleted the fix/ns-router-link-active branch September 1, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Plugins Team
  
Done
Development

Successfully merging this pull request may close these issues.

Angular 9,10 NSRouterLinkActive does not set CSS class
2 participants