Skip to content

Set this._isInitialized after preparePlatform in order before-prepare hooks to work properly #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Set this._isInitialized after preparePlatform in order before-prepare hooks to work properly #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/services/livesync/livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,14 @@ class LiveSyncService implements ILiveSyncService {
public liveSync(platform: string): IFuture<void> {
return (() => {
platform = this.$liveSyncServiceBase.getPlatform(platform).wait();
this._isInitialized = true;
let platformLowerCase = platform.toLowerCase();

if (!this.$platformService.preparePlatform(platformLowerCase).wait()) {
this.$errors.failWithoutHelp("Verify that listed files are well-formed and try again the operation.");
}

this._isInitialized = true; // If we want before-prepare hooks to work properly, this should be set after preparePlatform function

let platformData = this.$platformsData.getPlatformData(platformLowerCase);
this.ensureAndroidFrameworkVersion(platformData).wait();

Expand Down