Gulp fails miserably with symlinks in node_modules, use glob and stat instead #1575
Conversation
| @@ -40,6 +40,7 @@ | |||
| "fibers": "https://github.com/icenium/node-fibers/tarball/v1.0.6.3", | |||
| "filesize": "3.1.2", | |||
| "gaze": "0.5.2", | |||
| "glob": "^7.0.3", | |||
| "gulp": "3.9.0", | |||
There was a problem hiding this comment.
do we need gulp now ?
There was a problem hiding this comment.
I have absolutely no idea :D Lets do a search.
vinylFilterSince may be dropped as well.
There was a problem hiding this comment.
gulp, vinyl-filter-since and through2 should be removed
PanayotCankov
force-pushed
the
cankov/symlink-change-detect
branch
2 times, most recently
from
55b90e0 to
ee064ac
Compare
|
Applied most of the comments in the PR |
… instead Get correct stat of file In some cases glob module caches the file's stat with relative paths, in other - with full paths. Make sure we have correct stat by checking relative and full path and in case they are both null, stat the file on our own glob uses forward slashes on Windows, normalize glob paths
PanayotCankov
force-pushed
the
cankov/symlink-change-detect
branch
from
3f554ff to
1baf546
Compare
|
I am very happy with the simplified dependencies. 👍 |
|
But, is this for master - 2.0 or release - 1.7? In latter case, the PR must be re-targeted. |
|
We've decided to use keep it against master branch :) |
|
run ci |
|
👍 tested on Linux as well, great work |
|
If there is a need I'll remove the glob dependency as it appears it has an issue or two when it comes to its cross platform features. However it would be nice if we can use it to filter the files used to change detect and copy to the |
Gulp fails miserably with symlinks in node_modules, use glob and stat instead
Now you can:
The gulp we used to detect changes in the installed modules used to fail internally due fs-ing
tns-core-modulessymlink.