Fix debugging for simulator when --emulator is not passed #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --emulator is not passed, CLI will try to debug on iOS Simulator in case there's one started (or CLI will start it). However the iOS debug service calls methods for debug on device and it fails. Use correct methods when the detected devices is emulator.
|
👍 |
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --emulator is not passed, CLI will try to debug on iOS Simulator in case there's one started (or CLI will start it).
However the iOS debug service calls methods for debug on device and it fails.
Use correct methods when the detected devices is emulator.
Fixes
tns debug ioswhen no devices are connected