Livesync service refactoring #1941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| if (installed) { | ||
| platformLiveSyncService.afterInstallApplicationAction(deviceAppData, localToDevicePaths).wait(); | ||
|
|
||
| if (device.applicationManager.canStartApplication()) { |
There was a problem hiding this comment.
You can call:
device.applicationManager.tryStartApplication(appIdentifier).wait();It does almost the same as your code :)
|
ping @rosen-vladimirov your feedback has been applied |
| let installed = this.tryInstallApplication(device, deviceAppData).wait(); | ||
|
|
||
| if(installed) { | ||
| device.applicationManager.tryStartApplication(deviceAppData.appIdentifier).wait(); |
There was a problem hiding this comment.
We should add an option here to call different action (in case when running debug + livesync). Perhaps it should be in platform-livesync-service-base to allow handling both ios and android.
KristinaKoeva
force-pushed
the
KristinaKoeva/LiveSync2
branch
from
7f2e693 to
3541c41
Compare
|
👍 |
| forceExecuteFullSync: boolean; | ||
| } | ||
|
|
||
| interface IPlatformLiveSyncService { | ||
| fullSync(postInstallAction?: (deviceAppData: Mobile.IDeviceAppData, localToDevicePaths: Mobile.ILocalToDevicePathData[]) => IFuture<void>): IFuture<void>; |
There was a problem hiding this comment.
the action is used even when app is already installed, so the name is not really correct. postAction seems better IMO, but it's just a suggestion, not a merge stopper :)
|
👍 great work |
…ons so that we could delete some platform specific ifs
KristinaKoeva
force-pushed
the
KristinaKoeva/LiveSync2
branch
from
3541c41 to
703e386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.