Fix failing android build command by forcing use of gradle #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's `platforms/android` directory, but in package.json there's no entry in `nativescript` for android platform, calling `tns build android` or any build related command will fail with error: `Cannot read property 'version' of undefined` The reason is that we are trying to check the version in package.json and check if it allows us to use gradle (previously Android builds required Ant). Prevent the error and force using gradle in such case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's
platforms/androiddirectory, but in package.json there's no entry innativescriptfor android platform, callingtns build androidor any build related command will fail with error:Cannot read property 'version' of undefinedThe reason is that we are trying to check the version in package.json and check if it allows us to use gradle (previously Android builds required Ant).
Prevent the error and force using gradle in such case.
NOTE: The issue can be reproduced when working in new repository and you've added the platforms directory to
.gitignorefile. After adding android platform, you'll notice changes in your package.json. Instead of commiting them, I've calledgit reset --hardwhich removed them from package.json, but I still have the platforms directory.