inherit verbose logging from --log trace command #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plamen5kov
force-pushed
the
plamen5kov/pass_verbose_logging
branch
from
9d27c1e to
0d190ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a user runs a command using the
--log tracewe don't enable verbose logging for the gradle build. The current workaround was to ask the user to go to platforms android and run the same command that CLI runs but with two additional flags.Solution
In order to enable our users to provide us with better logs of error while building an application, this PR uses the
--log tracecommand to pass two additional debug flags to the gradle build.Usage:
No difference in usage of commands.
e.g.
tns run android --log traceping: @tzraikov @PanayotCankov @hdeshev