Skip to content

Fixed: Confusing report for a problem with CocoaPods during installation #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Fixed: Confusing report for a problem with CocoaPods during installation #2410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/node-package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ export class NodePackageManager implements INodePackageManager {
private getFlagsString(config: any, asArray: boolean) : any{
let array:Array<string> = [];
for(let flag in config) {
if(config[flag]) {
if (flag === "global") {
array.push(`--${flag}`);
array.push(`${config[flag]}`);
} else if(config[flag]) {
if(flag==="dist-tags" || flag==="versions") {
array.push(` ${flag}`);
continue;
Expand Down
2 changes: 1 addition & 1 deletion lib/services/doctor-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ class DoctorService implements IDoctorService {
let spinner = new clui.Spinner("Installing iOS runtime.");
try {
spinner.start();
this.$npm.install("tns-ios", projDir, { "ignore-scripts": true, production: true, save: true}).wait();
this.$npm.install("tns-ios", projDir, { global: false, "ignore-scripts": true, production: true, save: true}).wait();
spinner.stop();
let iosDir = path.join(projDir, "node_modules", "tns-ios", "framework");
this.$fs.writeFile(
Expand Down