Skip to content

Fix prepare scoped dependency with native code #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix prepare scoped dependency with native code #2835

wants to merge 1 commit into from

Conversation

petekanev
Copy link
Contributor

Preparing a scoped dependency containing platforms wouldn't remove them in the prepared tns_modules location because the path built was wrong.

@petekanev petekanev mentioned this pull request May 22, 2017
Merged
@petekanev petekanev closed this May 23, 2017
@petekanev
Copy link
Contributor Author

Closed in favor of #2837

@petekanev petekanev deleted the pete/fix-prepare-remove-platforms-scoped-deps branch July 10, 2017 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosen-vladimirov rosen-vladimirov Awaiting requested review from rosen-vladimirov

1 more reviewer

@dtopuzov dtopuzov dtopuzov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@petekanev @dtopuzov