ignore .(anything) files when checking for changes #3237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtopuzov
approved these changes
Dec 3, 2017
| @@ -219,6 +219,12 @@ export class ProjectChangesService implements IProjectChangesService { | |||
| } | |||
|
|
|||
| private containsNewerFiles(dir: string, skipDir: string, projectData: IProjectData, processFunc?: (filePath: string, projectData: IProjectData) => boolean): boolean { | |||
|
|
|||
| // ignore directories and files ending with .something (.bin, .git ...) | |||
| if (/.*[/\\]\.[^/\\]*$/.test(dir)) { | |||
There was a problem hiding this comment.
While this code is correct I would prefer a non-regex approach. For example:
const dirName = path.basename(dir);
if (_.startsWith(dirName, '.')) {
return false;
}I think that a bit more readable.
Plamen5kov
force-pushed
the
plamen5kov/ignore-hidden-files
branch
from
c248136 to
0fe4a2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if files are changed we should ignore all files ending in
.(something)as these files are hidden on mac and usually shouldn't be modified anyway.This will make livesync work a bit faster when
--sync-all-filesflag is used, because there are a number of.(something)directories inside.