fix(plugin-build): strip npm scope names from android plugin names #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Mar 12, 2018
|
run CI |
Plamen5kov
force-pushed
the
pete/rebuild-aar-patch2
branch
from
0674e65 to
54a5c73
Compare
Plamen5kov
force-pushed
the
pete/rebuild-aar-patch2
branch
from
360e276 to
19c178c
Compare
Plamen5kov
force-pushed
the
pete/rebuild-aar-patch2
branch
from
19c178c to
70574a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge before: telerik/mobile-cli-lib#1063
Problem:
Plugins contained within an npm scope, like
@nota/nativescript-accessibility-extfail to build because their android plugin name becomes@nota/nativescript-accessibility-ext, both@and/are illegal characters in an Android package name.Proposed solution:
Split the plugin name string by a forward slash (
/) and take the last element, effectively removing all forward slashes, and omitting the npm scope name, if any.