Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect iOS devices connected by USB only #3594

Merged
merged 1 commit into from
May 17, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented May 17, 2018

Currently CLI detects iOS Devices with Wi-Fi sync enabled. However, we can only detect them, but we are not able to deploy and livesync applications on them. This also breaks the workflow with devices connected by USB, but with Wi-Fi sync enabled.
So detect only the USB connected devices and disregard the ones connected with Wi-Fi sync enabled. This is handled in the 0.4.11 version of ios-device-lib, so just update the version: https://github.com/telerik/ios-device-lib/releases/tag/v0.4.11

PR Checklist

What is the current behavior?

Devices with Wi-Fi sync enabled are detected by CLI, but it cannot work with them. Also devices connected with USB cable and Wi-Fi sync enabled are not usable as CLI fails to deploy/livesync the applications.

What is the new behavior?

Devices with Wi-Fi sync enabled are not detected anymore.
Devices connected with USB cable and Wi-Fi sync enabled can be used without interruption.

Fixes #1398

Currently CLI detects iOS Devices with Wi-Fi sync enabled. However, we can only detect them, but we are not able to deploy and livesync applications on them. This also breaks the workflow with devices connected by USB, but with Wi-Fi sync enabled.
So detect only the USB connected devices and disregard the ones connected with Wi-Fi sync enabled. This is handled in the 0.4.11 version of ios-device-lib, so just update the version
@rosen-vladimirov rosen-vladimirov added this to the 4.1.0 milestone May 17, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this May 17, 2018
@rosen-vladimirov
Copy link
Contributor Author

run ci

@rosen-vladimirov rosen-vladimirov merged commit 8655173 into master May 17, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/update-ios-device-lib branch May 17, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants