chore: Merge release in master #3706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tests are initialized, the `tns test <platform>` command fails in case karma 2.0.3 is used. In order to fix it, until karma resolves the issue on their side, hardcode the version of karma that is installed by CLI on `tns test init` command. Also install mocha when it is selected for testing framework. In case we do not install it, the test command fails again.
Bump version to 4.1.2
chore: Bump version to 4.1.2
fix: Trying to run unit test fails with latest karma
Trying to execute execute tests with jasmine fails, as during initialization we have written incorrect data in karma.config.js file. The error is: `Error: No provider for “framework:undefined”! (Resolving: framework:undefined)` The problem is that during initalization we set undefined for framework value. Fix the initalization code to enter correct data in karma.config.js
…no-mocha fix(unit-testing): Fix tests executed with jasmine
Update Changelog for 4.1.2
docs: Update Changelog for 4.1.2
Fatme
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release in master