fix: validate bundle version on tns preview --bundle and tns run --hmr commands
#3956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Oct 1, 2018
| } | ||
|
|
||
| if (minSupportedVersion) { | ||
| const currentVersion = hasBundlerPluginAsDependency || hasBundlerPluginAsDevDependency; |
There was a problem hiding this comment.
the names of the properties seems incorrect, maybe bundlerVersionInDependencies and bundlerVersionInDevDependencies seems more appropriate
| const currentVersion = hasBundlerPluginAsDependency || hasBundlerPluginAsDevDependency; | ||
| const isBundleSupported = semver.gte(semver.coerce(currentVersion), semver.coerce(minSupportedVersion)); | ||
| if (!isBundleSupported) { | ||
| this.$errors.fail(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion)); |
There was a problem hiding this comment.
failWithoutHelp maybe, the command help may not help here
Fatme
force-pushed
the
famte/validate-bundle-version
branch
2 times, most recently
from
0ad4f6b to
f6e6532
Compare
rosen-vladimirov
approved these changes
Oct 4, 2018
| expectedError: null | ||
| }, | ||
| { | ||
| name: `should not throw an error when webpack's version is grather than minSupportedVersion when webpack is installed as ${key}`, |
Fatme
force-pushed
the
famte/validate-bundle-version
branch
from
f6e6532 to
1502957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
No error message is shown when installeld
nativescript-dev-webpackplugin does not supporthmroption orpreview-synchook.What is the new behavior?
An error message is shown when installeld
nativescript-dev-webpackplugin does not supporthmroption orpreview-synchook.