Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yarn.lock file #4113

Merged
merged 1 commit into from
Nov 14, 2018
Merged

feat: add yarn.lock file #4113

merged 1 commit into from
Nov 14, 2018

Conversation

KristianDD
Copy link
Contributor

PR Checklist

What is the current behavior?

We don't have a yarn.lock file and this might break us if any dependency, which is dependency of our dependency and is defined with exact version, releases a breaking patch version.

What is the new behavior?

We have yarn.lock file which ensures we have consistent versions of CLI dependencies when CLI is installed with yarn.

Fixes/Implements/Closes #4103

@KristianDD KristianDD self-assigned this Nov 8, 2018
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ensure the file is included in the built package

@KristianDD
Copy link
Contributor Author

@rosen-vladimirov Just checked it and grunt pack includes the yarn.lock inside the produced .tgz.

@KristianDD KristianDD merged commit 1937f29 into master Nov 14, 2018
@KristianDD KristianDD deleted the kddimitrov/add-yarn-lock branch November 14, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants